Skip to content

main.js: remove ancient versions code #3842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Apr 29, 2022
Merged

main.js: remove ancient versions code #3842

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4f123
main.js: remove ancient versions code
XhmikosR May 3, 2021
3c58bda
Merge branch 'main' into XhmikosR-patch-2
Trott Mar 15, 2022
04c313f
Merge branch 'main' into XhmikosR-patch-2
Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions static/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,6 @@
for (var i = 0; i < linkEls.length; i++) {
Copy link
Copy Markdown
Contributor Author

@XhmikosR XhmikosR May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd change this to a forEach since it's shorter, but maybe later.

Copy link
Copy Markdown

@ghost ghost Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact it does no obvious performance improvement, so I think this can be changed later :)

version = linkEls[i].getAttribute('data-version');
el = linkEls[i];

// Windows 64-bit files for 0.x.x need to be prefixed with 'x64/'
if (os === 'Win' && version[1] === '0' && arch === 'x64') {
el.href += arch + '/';
}

el.href += filename.replace('%version%', version);
}
}
Expand Down