Skip to content

vnu-jar.js: switch to execFile#3843

Merged
XhmikosR merged 4 commits intomasterfrom
XhmikosR-patch-3
Aug 19, 2021
Merged

vnu-jar.js: switch to execFile#3843
XhmikosR merged 4 commits intomasterfrom
XhmikosR-patch-3

Conversation

@XhmikosR
Copy link
Copy Markdown
Contributor

@XhmikosR XhmikosR commented May 3, 2021

No description provided.

@XhmikosR XhmikosR force-pushed the XhmikosR-patch-3 branch from 1ea2ce0 to 383c0f9 Compare May 3, 2021 06:24
@XhmikosR XhmikosR marked this pull request as ready for review May 3, 2021 06:26
@XhmikosR
Copy link
Copy Markdown
Contributor Author

XhmikosR commented May 3, 2021

BTW I'm still not sure if this script is as optimal as it could be (I don't even remember why I had to use spawn for example). Any help to improve it is welcome.

@nschonni
Copy link
Copy Markdown
Member

nschonni commented May 3, 2021

Is there a benifit to using the script vs something like https://github.com/w3c/aria-practices/blob/ea4ade330500ac65cf1e4e3334de892c2a42cec7/package.json#L22

@XhmikosR
Copy link
Copy Markdown
Contributor Author

XhmikosR commented May 3, 2021

Yeah. I believe only Windows 32-bit support. Ideally the needed workaround should be upstream, but time...

@XhmikosR XhmikosR merged commit b01ff5e into master Aug 19, 2021
@XhmikosR XhmikosR deleted the XhmikosR-patch-3 branch August 19, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants