improve: refer the Nodejs history links in one file#4050
Merged
3 commits merged intomasterfrom Aug 20, 2021
unknown repository
Merged
improve: refer the Nodejs history links in one file#40503 commits merged intomasterfrom unknown repository
3 commits merged intomasterfrom
unknown repository
Conversation
ghost
commented
Aug 16, 2021
ghost
requested a review
from 
nschonni
previously requested changes
Aug 16, 2021
nschonni
reviewed
Aug 17, 2021
Due to this sample (#4049) and many other related samples, it seems Node.js' history links are very easily forgotten by us and we have to maintain files one by one. This fixture will let all the files refer the same 'nodeVersionLinks.md', which means what we do now is just to modify this file instead of modifying translated files one by one in case of missing.
nschonni
dismissed
their stale review
Metalsmith isn't allowing Partials/Blocks with current plugins
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to this sample (#4049) and many other related samples, it seems Node.js' history links are very easily forgotten by us and we have to maintain files one by one. This fixture will let all the files refer the same 'nodeVersionLinks.md', which means what we do now is just to modify this file instead of modifying translated files one by one in case of missing.