Skip to content

improve Dark Mode #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SEWeiTung merged 2 commits into from
Oct 10, 2021
Merged

improve Dark Mode #4159

SEWeiTung merged 2 commits into from
Oct 10, 2021

Conversation

@SEWeiTung
Copy link
Contributor

@SEWeiTung SEWeiTung commented Oct 9, 2021

Ref: #4139.

  1. Change the header's background color to make it more light so as to
    be enhanced according to @Trott's idea.
  2. Fix the blog's "code" part and its font color to make it more
    visible.

FixMe

Blog

@SEWeiTung
Copy link
Contributor Author

SEWeiTung commented Oct 9, 2021

@NriotHrreion, @Trott. Plz have a review, thanks!

NriotHrreion
NriotHrreion suggested changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@NriotHrreion NriotHrreion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The switcher's position is not suitable for the mobile client.
It's better to move it to the center.

image

@Trott
Copy link
Member

Trott commented Oct 9, 2021

I've never noticed it until this PR, but the highlighting in the docs vs. the rest of the website is very different.

About page:

image

Docs:

image

@Trott
Copy link
Member

Trott commented Oct 9, 2021

Doesn't necessarily need to be fixed in this PR because it's already a problem on the main branch so could be fixed separately, but at certain viewport widths, the dark mode/light mode toggle sits on top of the News nav item:

image

@SEWeiTung
Copy link
Contributor Author

SEWeiTung commented Oct 10, 2021

@Trott: Here's my fix for the background color of code...ect (The same color as what we in in the doc).

About
Blog

@NriotHrreion: The problem you've mentioned above doesn't only appear in the dark mode, but in the light mode (Not only for your icon, but the language picker as well). I'll create another Bug issue to re-produce it in detail. So please cancel your reject request here because it doesn't belong to this fix ;)

@SEWeiTung
Copy link
Contributor Author

SEWeiTung commented Oct 10, 2021 •
edited
Loading

Related Issue: #4166

Maledong and others added 2 commits October 10, 2021 10:46
improve Dark Mode
3489fcd 
Ref: #4139.

1. Change the header's background color to make it more light so as to
   be enhanced according to @Trott's idea.
2. Fix the blog's "code" part and its font color to make it more
   visible.
Merge branch 'main' into improveDarkMode
9ec7f84
NriotHrreion
NriotHrreion approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@NriotHrreion NriotHrreion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK, LGTM

@SEWeiTung SEWeiTung merged commit 670a389 into nodejs:main Oct 10, 2021
@SEWeiTung SEWeiTung deleted the improveDarkMode branch October 10, 2021 04:20
@NriotHrreion
Copy link
Contributor

NriotHrreion commented Oct 12, 2021 •
edited
Loading

@MaledongGit: The switcher is still have a problem. I fixed that. See: #4174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

+1 more reviewer

@NriotHrreion NriotHrreion NriotHrreion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SEWeiTung @Trott @NriotHrreion