Skip to content

Conversation

@Ve33y
Copy link
Contributor

@Ve33y Ve33y commented Jun 5, 2023

Description

Moved "collaborating"-specific snippets and sections from CONTRIBUTING to COLLABORATOR_GUIDE. Added an update to how to add translations. (TRANSLATIONS needs a double check to make sure it's the expected update since it was not part of the issue but a slack thread)

Related Issues

#5413

Ve33y and others added 3 commits June 5, 2023 16:10
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Vessy <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
@Ve33y Ve33y requested a review from a team as a code owner June 5, 2023 20:13
@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org-stories ✅ Ready (Inspect) Visit Preview Jun 5, 2023 8:14pm

@vercel
Copy link

vercel bot commented Jun 5, 2023

@Ve33y is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 5, 2023 20:14 Inactive
@Ve33y
Copy link
Contributor Author

Ve33y commented Jun 5, 2023

@ovflowd & @mikeesto - closed #5416 and opened this one for cleaner commit history. Thank you both!

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ve33y, nice work

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you again, @Ve33y

@ovflowd ovflowd merged commit a3e95d1 into nodejs:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants