chore: add validation instructions to pr template#5506
Merged
bmuenzenmeyer merged 3 commits intonodejs:mainfrom Jul 17, 2023
Merged
chore: add validation instructions to pr template#5506bmuenzenmeyer merged 3 commits intonodejs:mainfrom
bmuenzenmeyer merged 3 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
HinataKah0
reviewed
Jul 13, 2023
HinataKah0
approved these changes
Jul 13, 2023
Contributor
HinataKah0
left a comment
HinataKah0
left a comment
There was a problem hiding this comment.
+1 on this for better workflow (although let's wait for other opinions as well).
A small nit is to rename it to Test Plan but let's see how other people think about it.
Thanks for bringing it up!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
lets go with this for now and see how it feels over time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull requests like #5500 created confusion as to what the actual bug and fix were. Reviewers had to compare old and new version of the code to determine the efficacy of the change.
This PR updates our pull request template to add a new section,
Validation. It provides brief guidance to the submitter as an HTML comment:Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing, and/ornpx turbo test:snapshotto update snapshots if I created and/or updated React Components.