Skip to content

chore: delete PreviousNextLink component#5709

Merged
ovflowd merged 1 commit intonodejs:mainfrom
HinataKah0:delete-previousnextlink
Aug 29, 2023
Merged

chore: delete PreviousNextLink component#5709
ovflowd merged 1 commit intonodejs:mainfrom
HinataKah0:delete-previousnextlink

Conversation

@HinataKah0
Copy link
Copy Markdown
Contributor

@HinataKah0 HinataKah0 commented Aug 29, 2023

Description

Delete PreviousNextLink component. It's being ported to the new website design but it's deleted to not complicate styles.

Validation

Run the following local commands:

  • npx turbo lint
  • npx turbo format
  • npx turbo test
  • npx turbo build
  • npx turbo serve

And see if Git pipeline succeed.

And also code search.

Screenshot 2023-08-29 at 10 17 30 PM Screenshot 2023-08-29 at 10 18 08 PM

Related Issues

Fixes #5705

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 2:16pm

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.03% (358/389) 77.89% (74/95) 87.95% (73/83)

Unit Test Report

Tests Skipped Failures Errors Time
41 0 💤 0 ❌ 0 🔥 9.411s ⏱️

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@HinataKah0 HinataKah0 marked this pull request as ready for review August 29, 2023 14:21
@HinataKah0 HinataKah0 requested a review from a team as a code owner August 29, 2023 14:21
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Aug 29, 2023
@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Aug 29, 2023

Fast-Tracking this PR as it is just code deletion.

@ovflowd ovflowd added this pull request to the merge queue Aug 29, 2023
Merged via the queue into nodejs:main with commit 161de20 Aug 29, 2023
@HinataKah0 HinataKah0 deleted the delete-previousnextlink branch August 29, 2023 15:15
@HinataKah0 HinataKah0 mentioned this pull request Aug 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete PreviousNextLink Component

3 participants