Skip to content

Conversation

@canerakdas
Copy link
Member

Description

A badge component was implemented with this PR.

  • Created a new directory called Badge within the Common directory.
  • Tailwind project colors and typography system applied. The design found in Figma was implemented with the tailwind.
  • Storybook added for exercising each of the badge's states.

Validation

image

Related Issues

fixes #5759

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner September 8, 2023 22:08
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 8:16pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 8, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 8, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 8, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 3.297s ⏱️

@canerakdas
Copy link
Member Author

@ovflowd Thanks for the review. I updated the PR 👍

@canerakdas canerakdas changed the title Badge component feat: add Badge component Sep 12, 2023
@AugustinMauroy
Copy link
Member

You should update from main to have theme addons. also update stories to use this addons.
And rest of pr it's LGTM.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! I left two minor comments 😀

Thank you for your first contribution! We really appreciate it!

Awesome work and hope to see more contributions in the future.

@canerakdas
Copy link
Member Author

Really good stuff! I left two minor comments 😀

Thank you for your first contribution! We really appreciate it!

Awesome work and hope to see more contributions in the future.

Thanks for the reviews and patience,

I learned much, and I will follow for future contributions 😄

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@mikeesto mikeesto added this pull request to the merge queue Sep 17, 2023
Merged via the queue into nodejs:main with commit 4d93098 Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Badge component

5 participants