Create NavItem component #5972
Merged
Create NavItem component #5972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Contributor
Unit Test Coverage Report
Unit Test Report
|
ovflowd
reviewed
Oct 8, 2023
ovflowd
reviewed
Oct 8, 2023
ovflowd
reviewed
Oct 8, 2023
github-actions
bot
removed
the
github_actions:pull-request
rodion-arr
approved these changes
Oct 9, 2023
AugustinMauroy
approved these changes
Oct 9, 2023
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGTM ! just we can add real link for polish ✨
ovflowd
reviewed
Oct 9, 2023
ovflowd
reviewed
Oct 9, 2023
ovflowd
reviewed
Oct 9, 2023
ovflowd
approved these changes
Oct 9, 2023
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
Re-approving. I just left a few final comments, and we're good to go! Thank you!
aymen94
approved these changes
Oct 9, 2023
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created NavItem component according to the requirements in issue 5911. Styled by matching the Figma styles to its equivalent Tailwind class.
Validation
Added all styles in light / dark mode for both Nav & footer types. Some screenshots below
Related Issues
Addresses issue 5911
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.