Skip to content

feat: sentry #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2023
Merged

feat: sentry #6099

merged 2 commits into from
Nov 9, 2023

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 8, 2023

Description

Introduces Sentry to the Node.js Website (Server-side, Edge-functions and Client-side)

@ovflowd ovflowd requested review from a team as code owners November 8, 2023 17:20
@vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 1:03pm

@ovflowd ovflowd added infrastructure Issues/PRs related to the Repository Infra accessibility Issues concerning accessibility github_actions:pull-request Trigger Pull Request Checks and removed accessibility Issues concerning accessibility labels Nov 8, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/blog 🟢 97 🟢 97 🟢 92 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
 78.97% (353/447) 63.46% (66/104) 62.22% (56/90)

Unit Test Report

Tests Skipped Failures Errors Time
54 0 💤 0 ❌ 0 🔥 5.257s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 8, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 8, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Nov 8, 2023

cc @nodejs/web-infra for review and approval ✅

AugustinMauroy
AugustinMauroy approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
i din't use a lot sentry but it's great tool

bmuenzenmeyer
bmuenzenmeyer requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really excited for this!

In addition to my comments, can you also add to https://github.com/nodejs/nodejs.org/blob/main/COLLABORATOR_GUIDE.md#technologies-used-in-the-website perhaps?

@ovflowd
Copy link
Member Author

ovflowd commented Nov 9, 2023

In addition to my comments, can you also add to main/COLLABORATOR_GUIDE.md#technologies-used-in-the-website perhaps?

Not relevant IMO. At least not to your average collaborator.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 9, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 9, 2023
@ovflowd @bmuenzenmeyer
chore: code review changes
7453a74 
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Claudio W <cwunder@gnome.org>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 9, 2023
@ovflowd ovflowd removed the accessibility Issues concerning accessibility label Nov 9, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 9, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Nov 9, 2023

cc @bmuenzenmeyer can you give an approval?

bmuenzenmeyer
bmuenzenmeyer approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great - dont really have a good way to test this so 🤞

we can always hotfix if something is messed up

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Nov 9, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Nov 9, 2023

cc @nodejs/web-infra let's get this merged as it's always great to have monitoring.

@ovflowd ovflowd merged commit 9a4f595 into main Nov 9, 2023
@ovflowd ovflowd deleted the feat/sentry branch November 9, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@canerakdas canerakdas canerakdas approved these changes

@flakey5 flakey5 flakey5 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

fast-track Fast Tracking PRs infrastructure Issues/PRs related to the Repository Infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ovflowd @bmuenzenmeyer @canerakdas @flakey5 @AugustinMauroy