fix: Blog page broken url #6112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
@canerakdas I think I didnt explain, but I wonder if instead of <> links you could transform into [] links? because then we can keep them relative instead of absolute which allows nextjs features to be taken in place |
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
ovflowd
approved these changes
Nov 13, 2023
Member
|
I'm fast-tracking this as a critical bug fix for certain links of the website. Thank you for taking care of this, @canerakdas! Super appreciate it! cc @nodejs/nodejs-website |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken blog links
Validation
In preview the links on the pages below should work without any problems;
https://nodejs.org/en/blog/announcements/v20-release-announce
https://nodejs.org/en/blog/announcements/v21-release-announce
https://nodejs.org/en/blog/release/v0.10.46
https://nodejs.org/en/blog/release/v0.12.15
https://nodejs.org/en/blog/release/v14.19.3
https://nodejs.org/en/blog/release/v17.9.1
https://nodejs.org/en/blog/release/v18.2.0
https://nodejs.org/en/blog/vulnerability/june-2023-security-releases
https://nodejs.org/en/blog/vulnerability/october-2023-security-releases
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.