fix(minor): Bash script on downloads page uses a command that is not installed on Mac#6343
fix(minor): Bash script on downloads page uses a command that is not installed on Mac#6343ovflowd merged 3 commits intonodejs:mainfrom focarroll:focarroll/issue3758
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
|
any reasons why this pr is on draft ? |
Unit Test Coverage Report
Unit Test Report
|
First PR on a major repository (not first PR overall) so I didn't want to make a dumb mistake. Gonna hit the "Ready for review" button. |
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for your first contribution 🎉
focarroll
changed the title
…being downloaded to the wrong location
|
That's embarrassing... I made a minor edit to the command when running it on my computer, but never changed the file before pushing. |
|
... |
|
All good :) |
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
The changes look good to me!
Thank you for your first contribution 🎉
github-actions
bot
removed
the
github_actions:pull-request
4 participants
Description
I made this issue (#3758) about three years ago and then forgot about it. Not knowing how to fix it, I left the solution as a comment and hoped someone would figure it out. Today, I received two emails about comments reminding me about this minor issue. Now knowing a bit more about Git, I've decided that it's finally time to put this issue to rest.
So long...
(this description is longer than the fix lol)
Validation
The package was downloaded and successfully installed to /usr/local/bin. Running node -v confirmed that v21.6.2 was installed.
Related Issues
Fixes #3758
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.