Skip to content

Conversation

@micheleriva
Copy link
Contributor

Description

This PR removes the heartbeat from Orama. It has been superseded by built-in heartbeat mechanisms.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@micheleriva micheleriva requested a review from a team as a code owner February 29, 2024 17:33
@vercel
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 5:35pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 29, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 98 🟠 83 🟢 91 🔗
/en/about 🟢 98 🟢 91 🟠 83 🟠 83 🔗
/en/about/previous-releases 🟢 98 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟠 83 🟢 91 🔗
/en/blog 🟢 99 🟢 96 🟠 83 🟢 92 🔗

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
80.18% (437/545) 79.09% (140/177) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.864s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Feb 29, 2024

Fast-tracking due to this creating issues on OramaCloud traffic.

@ovflowd ovflowd merged commit ffee760 into nodejs:main Feb 29, 2024
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants