Skip to content

chore(branding): introduce branding page#6435

Merged
ovflowd merged 6 commits intomainfrom
branding
Mar 8, 2024
Merged

chore(branding): introduce branding page#6435
ovflowd merged 6 commits intomainfrom
branding

Conversation

@AugustinMauroy
Copy link
Copy Markdown
Member

Description

Adding logo page call "branding" but I didn't add Design system.

Related Issues

Close #5545

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested review from a team as code owners March 4, 2024 14:26
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 8, 2024 8:09pm

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 5, 2024

image

Can you use a table here, instead of one logo per line?

@ovflowd

This comment was marked as outdated.

@AugustinMauroy
Copy link
Copy Markdown
Member Author

Can you use a table here, instead of one logo per line?

and what do you thinks about using flex and wrap for line return ?

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 5, 2024

Can you use a table here, instead of one logo per line?

and what do you thinks about using flex and wrap for line return ?

Let's make a table with three two columns and two rows:

  • dark image | light image
  • link to asset | link to asset

Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you fix @mikeesto requests, all good!

@AugustinMauroy
Copy link
Copy Markdown
Member Author

After you fix @mikeesto requests, all good!

FYI He proposed changes to the text that we removed the one about nodejs website design system. So there are nothing to do.

@AugustinMauroy AugustinMauroy added content Issues/pr concerning content github_actions:pull-request Trigger Pull Request Checks labels Mar 5, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 90 🟢 100 🟢 92 🔗

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
80.03% (449/561) 79.55% (144/181) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.433s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 8, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 8, 2024
@ovflowd ovflowd enabled auto-merge March 8, 2024 20:07
@ovflowd ovflowd added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit f259bee Mar 8, 2024
@ovflowd ovflowd deleted the branding branch March 8, 2024 20:14
@AugustinMauroy AugustinMauroy mentioned this pull request Mar 8, 2024
5 tasks
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Mar 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Issues/pr concerning content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Logo Page

4 participants