chore: Clean up homepage code examples (tweak comments + no wrapping)#6470
chore: Clean up homepage code examples (tweak comments + no wrapping)#6470
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
21539ac to
02f478e
Compare
|
Lighthouse Results
|
Heh, I thought I'd fixed that. Will continue playing around with getting flex + grid to behave. I suspect I need to throw some more max-w-full onto things. Open to suggestions on a cleaner way to make that happen. |
|
Just to confirm, scrolling is only on mobile, right? The intended behaviour on desktop is wrapping |
Not currently, I have this set to scroll everywhere. Why would it want to wrap on desktop, that seems like a rather inconsistent behaviour that looks odd? |
mwenku
left a comment
There was a problem hiding this comment.
Here to learn something new... :)
ovflowd
left a comment
There was a problem hiding this comment.
LGTM! Let's see how it looks like and the feedback we get
Description
Ensures that tabs + code don't allow for whitespace wrapping outside of what is in the source, preferring to overflow with scrolling within their container. I should note that I tried my best to resolve some responsiveness issues that this introduces (hence setting some max/min widths to stop grid/flex overflowing -- that being said, it looks like there are general responsiveness issues on these pages beyond this change (especially around tablet breakpoints).
Also, cleans up the comments in the examples to better follow what I think the user flow would be for trying them out, as I'd noted in #6457 (review)
Validation
On mobile + desktop, the code examples on the homepage behave as one would expect them to. On mobile, you can scroll the tabs + code to see more, rather than it wrapping.
Related Issues
Fixes #6388
Check List
npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.npx turbo buildto check if the website builds without errors.