Skip to content

chore: Setup i18n for general for Bengali language#6512

Merged
bmuenzenmeyer merged 3 commits intonodejs:mainfrom
nomandhoni-cs:bn-bengali-language-translation
Jun 15, 2024
Merged

chore: Setup i18n for general for Bengali language#6512
bmuenzenmeyer merged 3 commits intonodejs:mainfrom
nomandhoni-cs:bn-bengali-language-translation

Conversation

@nomandhoni-cs
Copy link
Copy Markdown
Contributor

Description

Setup i18n for general for Bengali language

  • Added bn in the config file array
  • Added bn.json in the /locales directory

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@nomandhoni-cs nomandhoni-cs requested a review from a team as a code owner March 24, 2024 08:17
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 0:24am

@nomandhoni-cs
Copy link
Copy Markdown
Contributor Author

Hi @bmuenzenmeyer,
I want to start working on the Bengali translation for the Node JS website.

I've added the bn in the config file array
Added bn.json in the /locales directory

In your free time, please have a look at the PR

@AugustinMauroy AugustinMauroy added the i18n Issues/PRs related to the Website Internationalisation label Mar 24, 2024
@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

bmuenzenmeyer commented Jun 13, 2024

Translation occurs via Crowdin. Per our guidelines, you only need to add the language to i18n/config.json

Additionally, this PR is out of date and needs a merge conflict fix. If you find it easier to re-open, go ahead.

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.617s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 15, 2024
Merged via the queue into nodejs:main with commit e1bd2e6 Jun 15, 2024
@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

added in crowdin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants