Skip to content

fix: numerous fixes regarding package manager page #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix: numerous fixes regarding package manager page #6638

merged 2 commits into from
Apr 15, 2024

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Apr 10, 2024

Description

This PR does a few fixes/changes as discussed on previous issues and as pointed out:

  • Remove the installation of the said package managers on the CodeBox snippets (except NVM, which is "universal" and specific to Node).js)
    • The reasoning is that folks will know how to install (and/or must have these package managers) preinstalled, such as Docker, Homebrew, and Chocolatey, as they are "OS" package managers, not Node.js package managers.
  • Add Docker option for Linux since we removed Docker installation instructions
  • Added warning that folks need to ensure that package managers are installed
  • Fixed height of the CodeBox section
  • Fixed bug that you couldn't switch between OSs (we were being too restrictive with one of the dropdowns)
  • Fixed Choco LTS package

Validation

  • Ensure functionality on the Package Manager tab is working as expected

Related Issues

Fixes #6637
Fixes #6479

@ovflowd ovflowd requested a review from a team as a code owner April 10, 2024 11:01
@vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 10, 2024 11:03am

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 10, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 10, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
 90.09% (582/646) 76.1% (172/226) 91.4% (117/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 5.683s ⏱️

AugustinMauroy
AugustinMauroy approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ovflowd ovflowd added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit b247d8c Apr 15, 2024
@ovflowd ovflowd deleted the fix/download-page-codeboxes branch April 15, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aymen94 aymen94 aymen94 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Install Node.js LTS version on windows by chocolate failed for the wrong Package Redesign is missing "Additional Platforms"

4 participants

@ovflowd @aymen94 @AugustinMauroy