Skip to content

Conversation

@chinmoykr
Copy link
Contributor

Unnecessary use of await

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Unnecessary use of await

Signed-off-by: chinmoykr <46194827+chinmoykr@users.noreply.github.com>
@chinmoykr chinmoykr requested a review from a team as a code owner April 11, 2024 17:56
@vercel
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 11, 2024 5:58pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! good catch

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Apr 15, 2024
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hotfix!

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

@ovflowd ovflowd enabled auto-merge April 15, 2024 08:09
@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.1% (583/647) 76.08% (175/230) 92.12% (117/127)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 5.476s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Apr 15, 2024
Merged via the queue into nodejs:main with commit 6f21c48 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants