Skip to content

Conversation

@huseeiin
Copy link
Contributor

@huseeiin huseeiin commented May 1, 2024

change lang from "js" to "cjs" for consistency

fixes this (first cjs, second js)
image

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

change lang from "js" to "cjs" for consistency

Signed-off-by: huseeiin <122984423+huseeiin@users.noreply.github.com>
@huseeiin huseeiin requested a review from a team as a code owner May 1, 2024 08:50
@vercel
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 1, 2024 8:52am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 93 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 96 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 5.713s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue May 3, 2024
Merged via the queue into nodejs:main with commit 050f395 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants