Skip to content

Conversation

@bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented May 21, 2024

Description

When reviewing the README it suggests the codebase still uses SCSS, when the code and documentation reflects otherwise.

Validation

N/A

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer added the fast-track Fast Tracking PRs label May 21, 2024
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner May 21, 2024 03:50
@vercel
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 21, 2024 3:50am

@bmuenzenmeyer
Copy link
Contributor Author

requested fast-track on this trivial PR.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label May 21, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 21, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 84 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 100 🟢 92 🔗

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.06% (589/654) 76.08% (175/230) 92.24% (119/129)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 6.355s ⏱️

@AugustinMauroy AugustinMauroy added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 966532d May 21, 2024
@AugustinMauroy AugustinMauroy deleted the README-STYLE branch May 21, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants