Skip to content

Conversation

@avivkeller
Copy link
Member

This PR updates the nvm install script to v0.40.0.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
@avivkeller avivkeller requested a review from a team as a code owner August 8, 2024 15:26
@vercel
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Aug 8, 2024 3:27pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.29s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure why the preview deploy is failing here - seems unrelated to the diff

@AugustinMauroy
Copy link
Member

we should do something like we had done on nodejs.dev
https://github.com/nodejs/nodejs.dev/blob/main/util-node/getNvmData.js

@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2024

Random Vercel failure, redeploying.

@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2024

we should do something like we had done on nodejs.dev nodejs/nodejs.dev@main/util-node/getNvmData.js

What are you talking about? We use NVM only for Husky to install Node on the environment.

@AugustinMauroy
Copy link
Member

What are you talking about? We use NVM only for Husky to install Node on the environment.

No no no, if you go on shared code you I'll see how on nodejs.dev we did to get the dynamic version of NVM

@ovflowd
Copy link
Member

ovflowd commented Aug 9, 2024

What are you talking about? We use NVM only for Husky to install Node on the environment.

No no no, if you go on shared code you I'll see how on nodejs.dev we did to get the dynamic version of NVM

Again, this is completely unrelated to this PR and that was used to render NVM version in a specific component. This has no use over here. Please avoid off-topic.

@ovflowd ovflowd added this pull request to the merge queue Aug 9, 2024
Merged via the queue into nodejs:main with commit 1606239 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants