-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: update nvm to v0.40.0 #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, not sure why the preview deploy is failing here - seems unrelated to the diff
|
we should do something like we had done on nodejs.dev |
|
Random Vercel failure, redeploying. |
What are you talking about? We use NVM only for Husky to install Node on the environment. |
No no no, if you go on shared code you I'll see how on nodejs.dev we did to get the dynamic version of NVM |
Again, this is completely unrelated to this PR and that was used to render NVM version in a specific component. This has no use over here. Please avoid off-topic. |
This PR updates the nvm install script to v0.40.0.
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.