Skip to content

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Aug 13, 2024

Setting NODE_ENV to anything but production is an antipattern should be avoided.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Setting NODE_ENV to anything but production is an antipattern should be avoided.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested a review from a team as a code owner August 13, 2024 06:56
@vercel
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 15, 2024 2:58am

…-between-development-and-production.md

Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
@AugustinMauroy
Copy link
Member

@ovflowd Any hint for recurring Vercel failure

@AugustinMauroy AugustinMauroy added content Issues/pr concerning content github_actions:pull-request Trigger Pull Request Checks labels Aug 13, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 13, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.404s ⏱️

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, I think it should be mentioned that many tools use this environment variable. And which it can still use. For example webpack

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really fantastic bit of clarification that Node.js should be using its platform to lead on - nice work!

…-between-development-and-production.md

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Merged via the queue into main with commit 0d30aa4 Aug 15, 2024
@bmuenzenmeyer bmuenzenmeyer deleted the mcollina-patch-1 branch August 15, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Issues/pr concerning content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants