-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
NODE_ENV is not part of Node.js core and an antipattern #6986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Setting NODE_ENV to anything but production is an antipattern should be avoided. Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...e/pages/en/learn/getting-started/nodejs-the-difference-between-development-and-production.md
Outdated
Show resolved
Hide resolved
…-between-development-and-production.md Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
|
@ovflowd Any hint for recurring Vercel failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, I think it should be mentioned that many tools use this environment variable. And which it can still use. For example webpack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really fantastic bit of clarification that Node.js should be using its platform to lead on - nice work!
...e/pages/en/learn/getting-started/nodejs-the-difference-between-development-and-production.md
Outdated
Show resolved
Hide resolved
…-between-development-and-production.md Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Setting NODE_ENV to anything but production is an antipattern should be avoided.
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.