Skip to content

test: release data coverage (7130) #7150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmuenzenmeyer merged 1 commit into from
Oct 31, 2024
Merged

test: release data coverage (7130) #7150

bmuenzenmeyer merged 1 commit into from
Oct 31, 2024

Conversation

@rakeshkumar1019
Copy link
Contributor

@rakeshkumar1019 rakeshkumar1019 commented Oct 29, 2024 •
edited
Loading

Description

Validation

Related Issues

Addresses #7130

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@rakeshkumar1019 rakeshkumar1019 requested a review from a team as a code owner October 29, 2024 02:04
@vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 29, 2024 2:06am

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Oct 29, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 96 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.51% (592/654) 75.21% (173/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.211s ⏱️

AugustinMauroy
AugustinMauroy approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Thanks for your contribution

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 31, 2024
mikeesto
mikeesto reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@mikeesto mikeesto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to try rerunning CI because this is building fine locally for me Ah the branch is 136 commits behind main

@bmuenzenmeyer bmuenzenmeyer merged commit d97bede into nodejs:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeesto mikeesto mikeesto left review comments

@aymen94 aymen94 aymen94 approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rakeshkumar1019 @aymen94 @mikeesto @AugustinMauroy @bmuenzenmeyer