Skip to content

fix: Consistent color transitions and Tailwind updates#7179

Merged
ovflowd merged 2 commits intonodejs:mainfrom
canerakdas:fix/consistent-color-transitions
Nov 6, 2024
Merged

fix: Consistent color transitions and Tailwind updates#7179
ovflowd merged 2 commits intonodejs:mainfrom
canerakdas:fix/consistent-color-transitions

Conversation

@canerakdas
Copy link
Copy Markdown
Member

@canerakdas canerakdas commented Nov 4, 2024

Description

With this PR, aimed to solve the problem of switching to light and then a dark theme during page transitions and to improve the tailwind adjustments in the following document;

https://tailwindcss.com/docs/upgrade-guide

Screen.Recording.2024-11-04.at.19.58.19.mov

Validation

There should be no flash(like) effect on page refreshes or transitions in the preview build

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner November 4, 2024 17:04
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 4, 2024 5:06pm

Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.5% (591/653) 76.06% (178/234) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.207s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Nov 6, 2024
Merged via the queue into nodejs:main with commit 9017bea Nov 6, 2024
bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
fix: color transitions and tailwind updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants