feat: display the reading time in a formatted for the locale #7495
Conversation
The display of the reading time for each page is currently based on the assumption that the page is in English. This change makes the Intl API is used to display the reading time in a format appropriate for the locale of the translated language.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/site/components/withMetaBar.tsx
Outdated
| const lastUpdated = frontmatter.date | ||
| ? formatter.dateTime(new Date(frontmatter.date), DEFAULT_DATE_FORMAT) | ||
| : undefined; | ||
| const readingTimeText = formatter.number(Math.round(readingTime.minutes), { |
There was a problem hiding this comment.
Why Math.round? As far as I know, Intl.NumberFormat rounds automatically.
There was a problem hiding this comment.
As far as I have tried, I needed Math.round() as follows.
There was a problem hiding this comment.
I’m using next-intl for this, is something wrong?
There was a problem hiding this comment.
Oh yeah I didn't see it. Oups my bad. So yeah we should try to avoid Math
There was a problem hiding this comment.
I'm not sure why we should avoid the standard Math functions, but I used the maximumFractionDigits option instead. How does this look?
There was a problem hiding this comment.
I'm not sure why we should avoid the standard Math functions, but I used the
maximumFractionDigitsoption instead. How does this look?
lgtm
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
Windows still failing |
5 participants
Description
The display of the reading time for each page is currently based on the assumption that the page is in English. This change makes the Intl API is used to display the reading time in a format appropriate for the locale of the translated language.
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.