feat: added new learn section with fetch examples #7499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
note, undici isn't re-exposed by node so need to add a npm add undici.
Member
|
you also need to add this news sub-section in navigation explained in CONTRIBUTING.md |
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
Why not making a sub-category ?
Member
|
cc @nodejs/undici |
okuryu
reviewed
Feb 17, 2025
metcoder95
reviewed
Feb 17, 2025
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Overall the examples lgtm, although I was under the impression that if the section is for fetch, maybe narrow more the guide to use fetch and how to extend it with undici?
metcoder95
reviewed
Feb 18, 2025
okuryu
reviewed
Feb 18, 2025
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Contributor
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
added
content
bjohansebas
reviewed
Feb 23, 2025
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new article under the getting-started section fetch.md that shows a few examples using undici.
Validation
Visit https://nodejs-org-git-fork-benhalverson-feat-fetch-openjs.vercel.app/en/learn/getting-started/fetch
Related Issues
#7492
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.