Skip to content

fix(heading): improve heading style #7628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

fix(heading): improve heading style #7628

merged 4 commits into from
Apr 11, 2025

Conversation

@AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Apr 7, 2025 •
edited
Loading

Description

Fix bugs introduced by migration of tailwind v4 or monorepo.

Validation

  • Headings with anchor shouldn't not change color when hoverd
  • correctly displayed when inline code is inside a code

Related Issues

No related issues just slack discussion

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Apr 7, 2025
Copilot AI review requested due to automatic review settings April 7, 2025 09:19
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner April 7, 2025 09:19
@vercel
Copy link

vercel bot commented Apr 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 10, 2025 7:45am

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • packages/ui-components/styles/markdown.css: Language not supported
  • packages/ui-components/styles/theme.css: Language not supported

@AugustinMauroy
fix typo in comment
4b6dc56 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
 95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
 84.73% (494/583) 76.03% (165/217) 86.99% (107/123)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.813s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.313s ⏱️

ovflowd
ovflowd reviewed Apr 7, 2025
View reviewed changes
ovflowd
ovflowd reviewed Apr 7, 2025
View reviewed changes
@avivkeller avivkeller changed the title Fix heading style fix(heading): improve heading style Apr 8, 2025
@avivkeller
Copy link
Member

avivkeller commented Apr 8, 2025

No related issues just slack discussion

For posterity, can you link the slack discussion?

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Apr 8, 2025

For posterity, can you link the slack discussion?

Normally it's okay now

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Apr 10, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 10, 2025
@avivkeller avivkeller removed the fast-track Fast Tracking PRs label Apr 10, 2025
@avivkeller avivkeller requested a review from ovflowd April 10, 2025 14:02
@ovflowd ovflowd added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 9fab28f Apr 11, 2025
14 checks passed
@ovflowd ovflowd deleted the fix-heading-style branch April 11, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@aymen94 aymen94 aymen94 approved these changes

@avivkeller avivkeller avivkeller approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

@ovflowd ovflowd Awaiting requested review from ovflowd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AugustinMauroy @avivkeller @ovflowd @aymen94 @bjohansebas