Skip to content

Conversation

@avivkeller
Copy link
Member

Looks like the required status checks might confuse the chromatic job id with the Tests job name. Naming them both Chromatic is probably a better idea

Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller added the fast-track Fast Tracking PRs label Apr 18, 2025
Copilot AI review requested due to automatic review settings April 18, 2025 12:44
@avivkeller avivkeller requested a review from a team as a code owner April 18, 2025 12:44
@vercel
Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 18, 2025 0:44am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the job name in the Chromatic workflow to reduce ambiguity between job ID and job name.

  • Renames the "Tests" job to "Chromatic" for consistency
  • Clarifies the intended purpose of the job within the workflow
Comments suppressed due to low confidence (1)

.github/workflows/chromatic.yml:46

  • Renaming the job to 'Chromatic' explicitly clarifies its purpose; ensure that any related documentation or comments reflect this update.
name: Chromatic

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.61%. Comparing base (1b0c5cb) to head (39cb9e6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7666   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          96       96           
  Lines        7689     7689           
  Branches      192      192           
=======================================
  Hits         5737     5737           
  Misses       1950     1950           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller
Copy link
Member Author

avivkeller commented Apr 18, 2025

@nodejs/web-infra

apologies for the incorrect information earlier, please adjust the required check to have a capital C in Chromatic.

this’ll need a push directly to main, since the required check technically does not exist until this PR lands (as it corresponds to name, not ID)

@avivkeller
Copy link
Member Author

Actually, does this even need to be a required check? not every PR needs a chromatic deployment?

@bmuenzenmeyer bmuenzenmeyer merged commit af1a888 into main Apr 18, 2025
21 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the Chromatic/Name branch April 18, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants