-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(chromatic): better job name #7666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the job name in the Chromatic workflow to reduce ambiguity between job ID and job name.
- Renames the "Tests" job to "Chromatic" for consistency
- Clarifies the intended purpose of the job within the workflow
Comments suppressed due to low confidence (1)
.github/workflows/chromatic.yml:46
- Renaming the job to 'Chromatic' explicitly clarifies its purpose; ensure that any related documentation or comments reflect this update.
name: Chromatic
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7666 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 96 96
Lines 7689 7689
Branches 192 192
=======================================
Hits 5737 5737
Misses 1950 1950
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Lighthouse Results
|
|
@nodejs/web-infra apologies for the incorrect information earlier, please adjust the required check to have a capital C in Chromatic. this’ll need a push directly to main, since the required check technically does not exist until this PR lands (as it corresponds to name, not ID) |
|
Actually, does this even need to be a required check? not every PR needs a chromatic deployment? |
Looks like the required status checks might confuse the
chromaticjob id with theTestsjob name. Naming them both Chromatic is probably a better idea