chore(learn): clarify wording in async article #7688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify wording. Signed-off-by: Thomas Amberg <tamberg@yaler.net>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avivkeller
approved these changes
Apr 26, 2025
bjohansebas
approved these changes
Apr 26, 2025
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7688 +/- ##
==========================================
+ Coverage 74.82% 74.84% +0.02%
==========================================
Files 98 98
Lines 7840 7888 +48
Branches 197 200 +3
==========================================
+ Hits 5866 5904 +38
- Misses 1972 1983 +11
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
araujogui
approved these changes
Apr 26, 2025
araujogui
requested changes
Apr 26, 2025
apps/site/pages/en/learn/asynchronous-work/javascript-asynchronous-programming-and-callbacks.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Guilherme Araújo <arauujogui@gmail.com> Signed-off-by: Aviv Keller <me@aviv.sh>
avivkeller
changed the title
araujogui
approved these changes
May 7, 2025
AugustinMauroy
approved these changes
May 7, 2025
github-actions
bot
removed
the
github_actions:pull-request
Member
|
Ugh this needs to be rebased. @tamberg can you rebase? |
Author
|
Not sure how to rebase. Just tried to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify wording.
Description
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.