Skip to content

Conversation

@avivkeller
Copy link
Member

Per #7738

Copilot AI review requested due to automatic review settings May 12, 2025 22:20
@avivkeller avivkeller requested a review from a team as a code owner May 12, 2025 22:20
@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 12, 2025 10:46pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pre-commit hook to use installed dependencies via pnpm instead of fetching them remotely with dlx.

  • Updated linting command from "pnpm dlx lint-staged" to "pnpm exec lint-staged".
  • Replaced the TypeScript build command with "pnpm check-types" to align with using installed dependencies.
Comments suppressed due to low confidence (2)

.husky/pre-commit:2

  • Switching from 'pnpm dlx lint-staged' to 'pnpm exec lint-staged' is a good move towards using installed dependencies. Please ensure that lint-staged is properly listed as a dependency to avoid runtime errors.
pnpm exec lint-staged

.husky/pre-commit:5

  • Replacing the TypeScript 'dlx tsc --build apps/site' command with 'pnpm check-types' simplifies dependency management. Verify that 'pnpm check-types' provides equivalent type checking coverage for your project.
pnpm check-types

@MattIPv4 MattIPv4 changed the title chore(pnpm): use installed dependencies chore(pnpm): use installed dependencies for pre-commit hook May 12, 2025
Co-authored-by: Matt Cowley <me@mattcowley.co.uk>
Signed-off-by: Aviv Keller <me@aviv.sh>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.87%. Comparing base (bf334d9) to head (d91e301).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7741      +/-   ##
==========================================
+ Coverage   74.83%   74.87%   +0.03%     
==========================================
  Files          98       98              
  Lines        7891     7895       +4     
  Branches      200      200              
==========================================
+ Hits         5905     5911       +6     
+ Misses       1985     1983       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 957fe3f May 14, 2025
16 checks passed
@avivkeller avivkeller deleted the use-installed-pnpm branch May 14, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants