chore(ci): run GHA on ready_for_review
#8286
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added conditions to run jobs only for non-draft pull requests. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Why? Is it not useful for folks to have CI (linting, tests, builds) run on draft PRs to check their work? |
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the GitHub Actions build workflow to add PR type filters and skip builds for draft pull requests.
- Added PR event type filters to trigger on specific PR lifecycle events
- Added a condition to skip builds for draft pull requests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8286 +/- ##
==========================================
+ Coverage 76.53% 76.57% +0.04%
==========================================
Files 117 117
Lines 9733 9733
Branches 329 328 -1
==========================================
+ Hits 7449 7453 +4
+ Misses 2282 2278 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
Putting a formal block on this until I understand what benefit having folks be blind to lint errors, test failures + build issues on drafts provides.
|
I'm okay with adding the additional triggers, but -1 on removing CI from draft PRs entirely |
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
avivkeller
changed the title
ready_for_review
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
Curious to see if this counts as a non-GitHub-Actions actor when you undraft a GHA PR
It does |
|
Fast tracking! |
Source: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
Description
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.