-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: update security best practices for current threat model #8374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Align examples with current SECURITY.md threat model - Add scenarios for malicious deps and prototype pollution - Document Node.js permission model usage - Refresh policy mechanism guidance and external security resources
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/security-wg Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8374 +/- ##
==========================================
+ Coverage 76.40% 76.41% +0.01%
==========================================
Files 118 118
Lines 9928 9928
Branches 334 334
==========================================
+ Hits 7585 7586 +1
+ Misses 2341 2340 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the security best practices documentation to align with the current Node.js threat model, clarifying the distinction between Node.js core vulnerabilities and application-level security concerns. The changes enhance the documentation with concrete examples, updated guidance on security mechanisms, and new information about the Node.js permission model.
- Adds clarifying introductions to major threat sections explaining the Node.js threat model scope
- Provides concrete, realistic examples for malicious dependencies and prototype pollution scenarios
- Documents the Node.js permission model as a runtime security mechanism
- Updates policy mechanism guidance and adds new external security resources
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
apps/site/pages/en/learn/getting-started/security-best-practices.md
Outdated
Show resolved
Hide resolved
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
|
Lighthouse Results
|
PTAL @nodejs/security-wg