Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/web-infra @nodejs/nodejs-website @nodejs/diagnostics Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8757 +/- ##
==========================================
- Coverage 75.27% 74.22% -1.06%
==========================================
Files 105 105
Lines 9242 8865 -377
Branches 326 326
==========================================
- Hits 6957 6580 -377
Misses 2283 2283
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the Learn section out of this repository by removing Learn content/layouts/navigation and redirecting Learn routes to the new dedicated site at https://learn.nodejs.org.
Changes:
- Remove Learn page content and the Learn-specific layout/navigation/i18n entries from this repo.
- Update site navigation and add redirects to route
/learn/*traffic tohttps://learn.nodejs.org/*. - Clean up ancillary repo metadata related to Learn (Crowdin ignore entries, CODEOWNERS, issue template, contributing text).
Reviewed changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/i18n/src/locales/en.json | Removes Learn sidebar navigation translation keys. |
| crowdin.yml | Removes Learn-page ignore patterns (Learn content removed from repo) and normalizes top-level YAML formatting. |
| apps/site/types/layouts.ts | Removes learn from the Layouts union. |
| apps/site/redirects.json | Redirects /learn/* and /:locale/learn/* to https://learn.nodejs.org/* and removes several prior Learn/guides-related redirects. |
| apps/site/pages/en/learn/typescript/transpile.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/typescript/run.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/typescript/run-natively.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/typescript/publishing-a-ts-package.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/typescript/introduction.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/test-runner/mocking.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/test-runner/introduction.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/test-runner/collecting-code-coverage.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/modules/publishing-node-api-modules.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/modules/abi-stability.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/writing-files-with-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/working-with-folders-in-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/working-with-file-descriptors-in-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/working-with-different-filesystems.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/reading-files-with-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/nodejs-file-stats.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/manipulating-files/nodejs-file-paths.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/http/enterprise-network-configuration.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/websocket.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/userland-migrations.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/the-v8-javascript-engine.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/profiling.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/nodejs-with-webassembly.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/nodejs-the-difference-between-development-and-production.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/introduction-to-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/how-much-javascript-do-you-need-to-know-to-use-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/fetch.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/ecmascript-2015-es6-and-beyond.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/differences-between-nodejs-and-the-browser.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/debugging.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/getting-started/an-introduction-to-the-npm-package-manager.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/user-journey.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/poor-performance/using-linux-perf.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/poor-performance/index.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/memory/using-heap-snapshot.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/memory/using-heap-profiler.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/memory/understanding-and-tuning-memory.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/memory/index.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/live-debugging/using-inspector.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/live-debugging/index.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/diagnostics/flame-graphs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/command-line/output-to-the-command-line-using-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/command-line/how-to-use-the-nodejs-repl.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/command-line/accept-input-from-the-command-line-in-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/understanding-setimmediate.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/understanding-processnexttick.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/the-nodejs-event-emitter.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/overview-of-blocking-vs-non-blocking.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/javascript-asynchronous-programming-and-callbacks.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/discover-promises-in-nodejs.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/discover-javascript-timers.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/learn/asynchronous-work/asynchronous-flow-control.md | Removes Learn article (moved to dedicated Learn repo/site). |
| apps/site/pages/en/about/get-involved/index.md | Updates “official learning materials” link to https://learn.nodejs.org/. |
| apps/site/navigation.json | Points top-nav Learn link to https://learn.nodejs.org and removes Learn side navigation tree. |
| apps/site/layouts/Learn.tsx | Removes Learn layout component. |
| apps/site/components/withLayout.tsx | Removes Learn layout registration. |
| CONTRIBUTING.md | Removes explicit mention of “learn articles” from contribution bullets. |
| .github/ISSUE_TEMPLATE/03-article-issue.yml | Removes Learn-article issue template. |
| .github/CODEOWNERS | Removes Learn-content CODEOWNERS entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
111
to
+118
| { | ||
| "source": "/:locale/community", | ||
| "destination": "/:locale/get-involved" | ||
| "source": "/learn/:path*", | ||
| "destination": "https://learn.nodejs.org/:path*" | ||
| }, | ||
| { | ||
| "source": "/:locale/docs/inspector", | ||
| "destination": "/:locale/learn/getting-started/debugging" | ||
| "source": "/:locale/learn/:path*", | ||
| "destination": "https://learn.nodejs.org/:path*" | ||
| }, |
There was a problem hiding this comment.
The new /learn redirects correctly send users to learn.nodejs.org, but legacy entry points like /guides (and previously also /:locale/guides and /:locale/docs/guides/) no longer have a redirect. This is likely to break existing inbound links that were historically mapped into Learn. Consider adding redirects for /guides, /:locale/guides, and any other removed /docs/guides/ aliases to the appropriate learn.nodejs.org URL(s) so old URLs continue to resolve.
Contributor
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
Member
I'm assuming this pr is also blocked on getting the subdomain setup for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #8612
Blocked-by: nodejs/admin#1050
Moves all learn references to https://learn.nodejs.org.
cc @nodejs/TSC