feat: add AI Coding Assistants Policy to footer#8807
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Fixes Reviewed by Cursor Bugbot for commit 91f3adf. Bugbot is set up for automated code reviews on this repo. Configure here. |
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8807 +/- ##
==========================================
- Coverage 74.23% 74.20% -0.04%
==========================================
Files 105 105
Lines 8870 8875 +5
Branches 328 329 +1
==========================================
+ Hits 6585 6586 +1
- Misses 2283 2287 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
MattIPv4
force-pushed
the
MattIPv4/footer-ai-policy
branch
from
67f945f to
4af1d55
Compare
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
There was a problem hiding this comment.
Pull request overview
Updates the site footer’s legal/policy links to include the OpenJS Foundation “AI Coding Assistants Policy” and align link ordering with the foundation-recommended set.
Changes:
- Add the “AI Coding Assistants Policy” footer link label and navigation entry.
- Update footer link ordering and switch the Code of Conduct URL to the OpenJSF hosted domain.
- Add the AI policy URL to the external-links list used for sitemap generation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/i18n/src/locales/en.json | Adds the English translation string for the new footer link label. |
| apps/site/next.constants.mjs | Adds the AI policy URL to EXTERNAL_LINKS_SITEMAP. |
| apps/site/next-env.d.ts | Updates the Next-generated route types import path. |
| apps/site/navigation.json | Adds/reorders footer links and updates the Code of Conduct URL. |
| apps/site/components/withLegal.tsx | Includes the new translation key in rich-translation link handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MattIPv4
changed the title
Description
Adds the new AI Coding Assistants Policy link to the footer, and also updates the ordering of the links in the footer based on the foundation's recommendation. The security policy is not in the foundation's regular set of links, but I have also updated the ordering of that to match the others, alphabetical. Also, this updates the code of conduct link to use the hostname redirect for consistency, matching the foundation's recommendation.
Also addresses an issue that Copilot spotted -- we include some external links in the sitemap, the ones from the footer, but these were being incorrectly prefixed with
https://nodejs.org/en.Validation
Footer links match https://github.com/openjs-foundation/artwork#copyright-notices-for-project-website-footers
Sitemap contains valid external URLs for the footer links.
Related Issues
cc openjs-foundation/artwork#27
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.