add chapter 5: cjs to esm migration#16
Merged
joyeecheung merged 2 commits intonodejs:mainfrom Jan 7, 2026
Merged
Conversation
Member
|
cc @nodejs/userland-migrations we need to transform this ressource into a codemod. |
ljharb
reviewed
Jan 6, 2026
Member
ljharb
left a comment
There was a problem hiding this comment.
This is awesome, only a few minor comments and one bigger one.
Member
Author
|
Updated, PTAL, thanks @ljharb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @nodejs/package-maintenance @nodejs/package-pathfinders
This is split into 4 subchatpers:
Each subchapter contains a before/after folder with the examples mentioned in the documentation, tested by test.mjs.