Skip to content

Revert "Add Separate Members Page"#117

Merged
mhdawson merged 83 commits intomasterfrom
revert-64-members-page
Dec 21, 2018
Merged

Revert "Add Separate Members Page"#117
mhdawson merged 83 commits intomasterfrom
revert-64-members-page

Conversation

@wentout
Copy link
Copy Markdown
Contributor

@wentout wentout commented Dec 20, 2018

Reverts #64

@mhdawson @mcollina @pertrai1
I have to merge this, cause there are to much conflicts.
I'd better re-do everything again after. Sorry.

MohammedEssehemy and others added 30 commits November 29, 2018 00:20
I've been using node for ~6 years and have been making small contributions to various projects. I'm interested in improving the quality, security and longevity of packages in the ecosystem to make my clients and users happier, and hopefully my life as a developer easier and saner.
Fix: readd myself to contributors
Hey! I saw the call to action on NodeWeekly. 

I've been using and building with Node for years now, and have been contributing to projects on Github. I've been wanting to get involved and help the core community, so this seems like a great place to start!

Thank you for considering me for the team.
I'm an OSS maintainer and contributor. I've started contributing to Node recently and I think this initiative is somewhere I can help.
I am the author of [Extended Memory Semantics](https://github.com/SyntheticSemantics/ems/) who recently abandoned my five year old Node.js add-on just as two companies [opened an issue](mogill/ems#20) or [filed a PR](mogill/ems#24) because EMS is an enabling technology for their companies.

My background is in High Performance Computing and emerging architectures, I have presented EMS at [Node Summit 2017](https://vimeo.com/229686658) and other invited talks and Meet-Ups.  I would like to represent a voice of volunteers who made possible the ecosystem that is today the full-time jobs of others.
Hi there!
I would love to share my knowledge and to contribute code to these awesome packages.
I would also like to offer any other assistance in this initiative! 💪
I've been using Node.js in production since 0.8.
I'm super interested in feeding back to the community and I held a Node Party in Shanghai, for native developers.
I think this project would make Node's eco system better. I'd try to help the package migration to newest Node.js version which I've done much in my own projects.
source. By I wasn't motivated enough to do so beyond checking "good first
issue" in nodejs github. I find this initiative as a great oppurtunity
to be motivated enough to contribute(with the help of others, of-course).
That being said, I am person who can be relied upon. I do not have any
preference in which way I like to contribute. If it is code, then that
would be great.

PS: I started contributing, right from the pull request. I fixed a
copy/paste error :-)
…cially, in defining/documenting process as well as devloping tools to help solve challanges mentioned by @mhdawson. Or any other technical contribution asked for.
I'm Saif Jerbi, Senior frontend developer @vermeg, i'm working with NodeJs for a while. I'm also a Developer advocate.
I'm looking to join the Project Team, i think i can help with writing articles about the ecosystem of nodeJS, Given feedbacks of the current ways we are using NodeJS in my Team(@work).
I'd like to share my experience by assisting with documentation and addressing open issues for packages.
@mikeattara used the github username for ghinks for his link text inadvertently.

This resolves that issue
Update documentation and fix whatever issue comes my way
@wentout
Copy link
Copy Markdown
Contributor Author

wentout commented Dec 21, 2018

@pertrai1 @Emuentes @mhdawson @mcollina

I think now it might happen as one.

Also, #21 seems missed, for @RahulPol. I will notify.
And seems #116 already made through other landing, so I will merge later.

Hope it will work.

To check how it will look like, you just have to switch the branch:
image

And as this branch is a branch of this PR #117, then it must ship all the commits of all contributors listed above, so they will receive:

contributor badge

Hope this will work, it should.

All in Good Time :)

@wentout wentout requested review from mcollina and mhdawson and removed request for mcollina December 21, 2018 01:13
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Copy Markdown
Member

Ok going to land as I think this moves us in the right direction and then we can check if we have captured all of the people.

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 2f4d132 into master Dec 21, 2018
@mhdawson
Copy link
Copy Markdown
Member

I was thinking that we would just close the PR's for all of the people we now have covered in the README.md. Any objections to that?

@wentout
Copy link
Copy Markdown
Contributor Author

wentout commented Dec 21, 2018

I was thinking that we would just close the PR's for all of the people we now have covered in the README.md. Any objections to that?

All PRs were made from their [fork]/master to [package-maintenance]/master.
And, I shipped them to the revert branch. And made MEMBERS.md simultaneously.

Now, as they received contributor's, seems all PRs shipped to master.
But still I have to click all PRs merge buttons, cause this action still required.

And I hoped github will auto-merge them, as my branch was merged having commits of PRs.
But seems not, it doesn't work the same way as other git systems, it requires interaction.

So, the part with contribution worked good. And part with merging worked bit too complicated.
Though I still able to merge all accordingly to merged PRs.

@wentout wentout deleted the revert-64-members-page branch December 21, 2018 18:09
@wentout wentout restored the revert-64-members-page branch December 21, 2018 18:20
@wentout wentout deleted the revert-64-members-page branch December 21, 2018 18:22
@wentout
Copy link
Copy Markdown
Contributor Author

wentout commented Dec 21, 2018

@mhdawson

So, yes, now I merged revert-64-members-page branch, and yes, everything is there now, all PRs are there and all statuses too. Sorry, I didn't knew it will require extra interaction.

Merry Christmas mates! ;^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.