fix: handle schema-less HTTP_PROXY env vars

[M-YasirGhaffar]

This relates to...

Fixes #4736

Rationale

When HTTP_PROXY or HTTPS_PROXY is set without a URL scheme (e.g., localhost:8080 instead of http://localhost:8080), the EnvHttpProxyAgent fails. This PR adds automatic http:// prefix for schema-less proxy URLs, matching Go's httpproxy behavior.

Changes

Added normalizeProxyUrl() helper function in lib/dispatcher/env-http-proxy-agent.js. Also added tests in test/env-http-proxy-agent.js.

Features

N/A

Bug Fixes

• Schema-less proxy URLs now work by assuming http:// protocol

Breaking Changes and Deprecations

None. This is additive behavior - existing URLs with explicit schemes are unchanged.

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• [S] Documented
• Review ready
• In review
• Merge ready

[mcollina]

cc @joyeecheung can you take a look as well?

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (fc8bb75) to head (f052510).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4809      +/-   ##
==========================================
- Coverage   93.26%   93.26%   -0.01%     
==========================================
  Files         109      109              
  Lines       34090    34098       +8     
==========================================
+ Hits        31794    31800       +6     
- Misses       2296     2298       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[metcoder95]

Will this require adjustments in Node for fetch besides the Undici upgrade?

[M-YasirGhaffar]

@metcoder95 This shouldn't require any changes for fetch. The normalization happens inside EnvHttpProxyAgent before the URL reaches ProxyAgent.

[joyeecheung]

As a user I'd find this behavior
a bit surprising....is there any tool other than the go package doing this convention?

[M-YasirGhaffar]

@joyeecheung curl does this. If you pass a proxy without a scheme it defaults to HTTP. git does too since it uses libcurl under the hood. Go's httpproxy package also prepends http:// when the scheme is missing.

I think if someone sets HTTP_PROXY=myproxy:8080, they'd expect it to work, especially since curl handles it fine. The change is also non-breaking, URLs with explicit schemes go through unchanged.

Sources:

• curl/libcurl: "HTTP Proxy. Default when no scheme or proxy type is specified."
• Go httpproxy: parseProxy() prepends http:// for schema-less values (line 153-158)
• git: uses libcurl for HTTP proxy handling, inherits the same behavior.

[joyeecheung]

Thanks for the pointers. I agree converging with what curl does is generally the safest.

[mcollina]

lgtm

[mcollina]

There are some related failures

[M-YasirGhaffar]

@mcollina could you point me to the specific failures? If you mean the macOS ECONNRESET in test/fetch/encoding.js and the Node 24/25 shared-builtin compilation ones, those seem unrelated to this change. Happy to dig further.