Skip to content

chore(deps): add lockfile#5139

Merged
mcollina merged 1 commit intonodejs:mainfrom
aduh95:lockfile
Apr 30, 2026
Merged

chore(deps): add lockfile#5139
mcollina merged 1 commit intonodejs:mainfrom
aduh95:lockfile

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 30, 2026

Given the recent supply-chain attacks, not having a lockfile puts at risk Undici contributors, and I couldn't find a reason for not having one.

I've copied the lockfile from https://github.com/nodejs/node/blob/main/deps/undici/src/package-lock.json.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.17%. Comparing base (1ca84b1) to head (7ec23c4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5139      +/-   ##
==========================================
+ Coverage   93.16%   93.17%   +0.01%     
==========================================
  Files         110      110              
  Lines       36220    36247      +27     
==========================================
+ Hits        33743    33774      +31     
+ Misses       2477     2473       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we do not have dependencies but rather only dev ones, don't see a strong reason to not have one

@metcoder95 metcoder95 requested review from mcollina and ronag April 30, 2026 10:40
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit bec4961 into nodejs:main Apr 30, 2026
34 of 35 checks passed
@aduh95 aduh95 deleted the lockfile branch April 30, 2026 11:44
@github-actions github-actions Bot mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants