Skip to content

test(websocket): fix flaky send test#5232

Merged
mcollina merged 1 commit intomainfrom
fix/websocket-send-flaky-5181
May 6, 2026
Merged

test(websocket): fix flaky send test#5232
mcollina merged 1 commit intomainfrom
fix/websocket-send-flaky-5181

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented May 6, 2026

Description

  • refactor test/websocket/send.js to use async/await with once(...)
  • register deterministic cleanup for every websocket client/server pair
  • wait for close events instead of resolving tests before teardown finishes

Fixes: #5181

Testing

  • npx borp -p "test/websocket/send.js"
  • npm run test:websocket
  • npm run lint

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (da0eebc) to head (16a6a4b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5232   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         110      110           
  Lines       36353    36353           
=======================================
+ Hits        33907    33909    +2     
+ Misses       2446     2444    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit 6445165 into main May 6, 2026
60 of 61 checks passed
@mcollina mcollina deleted the fix/websocket-send-flaky-5181 branch May 6, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flaky] test/websocket/send.js

4 participants