Skip to content

test(websocket): fully deflake send test#5236

Open
mcollina wants to merge 1 commit intomainfrom
fix/websocket-send-flaky-5181-followup
Open

test(websocket): fully deflake send test#5236
mcollina wants to merge 1 commit intomainfrom
fix/websocket-send-flaky-5181-followup

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented May 6, 2026

Description

  • finish deflaking test/websocket/send.js
  • await open, message, and close events deterministically with once(...)
  • register cleanup that waits for websocket client/server teardown before test exit
  • avoid the close-event race in Sending data after close by subscribing before closing

Follow-up to #5232
Related: #5181

Testing

  • npx borp -p "test/websocket/send.js"
  • repeated 50x npx borp -p "test/websocket/send.js"
  • npm run test:websocket
  • npm run lint

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (e58fff7) to head (871481e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5236   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         110      110           
  Lines       36353    36366   +13     
=======================================
+ Hits        33909    33922   +13     
  Misses       2444     2444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants