Skip to content

ci: align codeql-action autobuild and analyze with init at v4.37.3 - #5655

Merged
mcollina merged 1 commit into
nodejs:mainfrom
ostapondo:fix-codeql-version-skew
Aug 5, 2026
Merged

ci: align codeql-action autobuild and analyze with init at v4.37.3#5655
mcollina merged 1 commit into
nodejs:mainfrom
ostapondo:fix-codeql-version-skew

Conversation

@ostapondo

@ostapondo ostapondo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This relates to...

CodeQL is failing on every PR right now, e.g.
https://github.com/nodejs/undici/actions/runs/31029528463/job/92399206703

Rationale

#5634 bumped codeql-action/init to v4.37.3 and left autobuild and analyze
on the v4.36.2 commit. Autobuild then chokes on the config init wrote:

Loaded a configuration file for version '4.37.3', but running version '4.36.2'

Changes

Move autobuild and analyze to the same commit init already uses. I checked
both hashes against the tags in github/codeql-action.

The # v2.3.3 comments on all three were wrong before this too, so they
are corrected here as well.

Features

N/A

Bug Fixes

N/A, CI only.

Breaking Changes and Deprecations

N/A

Status

  • I have read and agreed to the Developer's Certificate of Origin
  • Tested. actionlint passes and the pinned hash matches the v4.37.3 tag.
  • Benchmarked, N/A
  • Documented, N/A
  • Review ready
  • In review
  • Merge ready

@ostapondo

Copy link
Copy Markdown
Contributor Author

@mcollina this one isn't just my branch, CodeQL is failing on everything right now including #5651. #5634 bumped init to 4.37.3 and left autobuild and analyze at 4.36.2, and they choke on the config init writes.

@codecov-commenter

codecov-commenter commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.42%. Comparing base (4ae29b2) to head (c597043).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5655   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         110      110           
  Lines       38723    38723           
=======================================
  Hits        36178    36178           
  Misses       2545     2545           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit f276009 into nodejs:main Aug 5, 2026
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants