fix(test): skip cache-tests when submodule is missing - #5661
Conversation
CITGM installs the published package without git submodules, so test/fixtures/cache-tests is empty and importing the runner fails the suite. Exit cleanly with a warning when the checkout is absent (fixes nodejs#5642).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5661 +/- ##
==========================================
+ Coverage 93.43% 93.45% +0.02%
==========================================
Files 110 110
Lines 38733 38776 +43
==========================================
+ Hits 36190 36238 +48
+ Misses 2543 2538 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI note: the Node 24/26 failures are in |
Previous run failed only on test/http2-request-never-settles.js; this change is unrelated to the cache-tests submodule skip.
|
Thanks @mcollina. Flagging that the red check is unrelated, so it doesn't hold this up by mistake.
That's the HTTP/2 suite timing out at ~10.1s. This PR touches a single file, Looks like a timing-sensitive flake on a shared runner. Happy to rebase to trigger a fresh run if you'd prefer a green tick before merging — I held off since a force-push can drop the approval. |
|
Ready to merge from our side — @mcollina already approved. The only red check is That same Node 24 job has also been failing on |
Summary
npm testrunstest:cache-tests, which importstest/fixtures/cache-tests/.../runner.mjs.Cannot find module '.../runner.mjs'(Test failure on CITGM for Node.js 26.6.0 #5642).Fixes #5642
Test plan
test/fixtures/cache-tests(no submodule):node test/cache-interceptor/cache-tests.mjs --ciexits 0 and prints the skip warningMade with Cursor