fetch: add serverKit for server runtimes - #5690
Draft
mcollina wants to merge 1 commit into
Draft
Conversation
Expose a single frozen namespace with the internals a server runtime needs to build Request/Response subclasses without the public constructors (kConstruct, HeadersList, headers list/guard accessors, request/response state accessors). Exported only through the Node.js bundle entry point. No behavior changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5690 +/- ##
==========================================
- Coverage 93.46% 93.46% -0.01%
==========================================
Files 110 111 +1
Lines 38777 38838 +61
==========================================
+ Hits 36241 36298 +57
- Misses 2536 2540 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes a single frozen
serverKitnamespace (via the Node.js bundle entry point only) with the fetch internals a server runtime needs to buildRequest/Responsesubclasses without the public constructors:kConstruct,HeadersList, headers list/guard accessors, and request/response state accessors.No behavior changes; the request/response modules only gain exports for accessors they already define.
Needed by Node.js core's
http.serve()to construct per-request fetch objects cheaply (nodejs/node PR to follow).