Skip to content

remove hard coded port 8080 for routes, services and deployment configs #216

@lholmquist

Description

@lholmquist

currently, nodeshift will hard code port 8080 for the "port" or "targetPort" for the routes, services, deploymentConfigs, health check(enricher)

We probably should not be hard coding these, but making them just the default.

I originally thought that a PORT=.... env var should change this, but i'm not entirely sure. I'm thinking more of a flag --deploy.port or similar.

I think the flag makes more sense here, since it is a value for something nodeshift is going to create, not how nodeshift should run.

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions