fix: remove the hardcoded 8080 for ports.#217
Merged
lholmquist merged 1 commit intoApr 23, 2018
Conversation
ghost
assigned
Member
Author
|
i've decided to make this a command line flag instead of reading an environment variable |
In the Service, DeploymentConfig, Route and Health Check Enricher, the port and targetPort values were hardcoded to 8080. This change adds the --deploy.port flag so a user can specify a port if they want. defaults to 8080 The enrichers for the aforementioned descriptors will now use that port value fixes nodeshift#216
lholmquist
force-pushed
the
216-remove-hardcoded-8080
branch
from
cc99608 to
bd3f10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Service, DeploymentConfig, Route and Health Check Enricher, the port and targetPort values were hardcoded to 8080.
This change adds the --deploy.port flag so a user can specify a port if they want. defaults to 8080
The enrichers for the aforementioned descriptors will now use that port value
fixes #216