Adding ability to supply an HTTP Agent#125
Merged
kr1sp1n merged 12 commits intonodevault:masterfrom Jun 11, 2020
Merged
Conversation
petercunha
reviewed
Jun 4, 2019
| mustache = config.mustache || mustache; | ||
| rp = (config['request-promise'] || rp).defaults({ | ||
|
|
||
| let rpDefaults = { |
There was a problem hiding this comment.
Please change this to a const. The linter is causing the travis build to fail.
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 139 143 +4
Branches 34 35 +1
=========================================
+ Hits 139 143 +4
Continue to review full report at Codecov.
|
petercunha
approved these changes
Jun 19, 2019
| mustache = config.mustache || mustache; | ||
| rp = (config['request-promise'] || rp).defaults({ | ||
|
|
||
| let rpDefaults = { |
Contributor
Author
|
Updated to latest master...believe it's good to go @petercunha |
|
Looks good, hopefully one of the maintainers will review it soon 👍 |
Collaborator
|
@seangallavan Thanks for your PR and sorry for the very late merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is helpful if you want to access vault behind a bastion.