Replace Request with Axios#190
Closed
brianphillips wants to merge 2 commits intonodevault:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 146 159 +13
Branches 37 42 +5
=========================================
+ Hits 146 159 +13
Continue to review full report at Codecov.
|
Author
|
@kr1sp1n Could you please let me know how to proceed, specifically with the |
Collaborator
|
@brianphillips see my comment here: #150 (comment) |
orgads
reviewed
Feb 16, 2022
brianphillips
force-pushed
the
replace-rp-with-axios
branch
from
0448f09 to
fc070bc
Compare
This was referenced Apr 24, 2022
Collaborator
|
Closing in favor of #150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebasing/fixup of #151.
One feature added after the original PR was submitted was the
rpOptionsconfiguration option which allows any option to be passed through torequest-promise(see #125). This is arguably a bit of a leaky abstraction and would be difficult to implement with any degree of completeness (it would require a full mapping of request options to axios options which seems beyond the scope of this module). It seems like the original intent was just to allow an agent to be passed through to the underlying request library (which could be easily accomplished). We could also consider allowing various Axios-specific options to be passed through but regardless, for now, I've just skipped the existing test that exercised therpOptionspending specific direction for how compatible we need to keep the API given the challenges I've mentioned.