Add rack 2 backwards compat#4
Merged
Merged
Conversation
`rack` version 2 two requires a `rack.input`, other than that it is 100% compatible with version 3 when it comes to the methods that linzer uses. Relaxing the version requirement this way allows people to adopt linzer that are stuck on `rack` 2 for whatever reason.
Owner
|
Thanks for this PR @oneiros. Earlier this year I considered exactly this, it would be a good idea to relax rack version requirement but didn't get to it for whatever reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
Please note that I had to add a tiny little thing to make this work with rack 2: rack 2 two requires a
rack.input, other than that it is 100% compatible with version 3 when it comes to the methods that linzer uses.I did make sure the specs pass with rack 2 and 3, but this PR does not include any fancy multi-version test setup (e.g. with the
appraisalgem).I consider this to be more of a stop-gap measure for now. Ideally I would like the requirement on rack be dropped altogether, but I will need to write this up in an issue before that can be discussed in any detail.
Also, if you do not like this change and/or do not wish to relax the version requirement in this or any other way, I totally understand this.