Removed custom_output_names from the separate file call.

[Kulin-Soni]

Removed custom_output_names from _separate_file call inside the _process_with_chunking method. This prevents the processed chunks from getting the same custom name, and have the chunk_N naming.

This prevents overwriting previous chunks.

This is a fix to #259

Summary by CodeRabbit

• Bug Fixes
  • Made chunked audio separation produce consistent output file naming when processing in chunks, preventing inconsistent or missing per-chunk custom names.
• Tests
  • Updated unit tests to reflect the optional per-chunk naming behavior and ensure state restoration after chunked processing remains correct.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a3962f03-0389-442f-9c15-dd5cf9886da8

📥 Commits

Reviewing files that changed from the base of the PR and between 2b0895f and 396a7dc.

📒 Files selected for processing (1)

• tests/unit/test_separator_chunking.py

---

Walkthrough

Removed the custom_output_names argument from the _separate_file call inside _process_with_chunking, and updated a unit test helper to make its custom_names parameter optional to match the new call site. (45 words)

Changes

Cohort / File(s)	Summary
Chunked processing change audio_separator/separator/separator.py	Omitted the custom_output_names argument when calling _separate_file() from _process_with_chunking(), removing per-chunk custom naming at the call site.
Test adjustment tests/unit/test_separator_chunking.py	Made the test helper track_state accept custom_names=None (optional) to align with the updated call that omits the parameter.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibbled a param, soft and light,
Chunks now hop through day and night,
Names tucked away, optional and free,
Simpler paths for you and me. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing custom_output_names parameter from the _separate_file call in _process_with_chunking method.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use your project's `ruff` configuration to improve the quality of Python code reviews.

Add a Ruff configuration file to your project to customize how CodeRabbit runs ruff.

[beveradb]

Can you make sure all the tests pass too please? 🙏

[Kulin-Soni]

sure, will do soon

[Kulin-Soni]

@beveradb Tests done!

[beveradb]

Hey @Kulin-Soni — thank you so much for identifying and fixing this bug! Your analysis of the issue was spot-on: passing custom_output_names to _separate_file for each chunk was causing them to overwrite each other.

I've incorporated your fix into #270 (now merged), which also adds a more comprehensive regression test that uses multiple chunks + multiple stems and explicitly verifies that _separate_file is called without custom names during chunk processing.

I'm going to close this PR as superseded, but want to make sure you know your contribution was the foundation of the fix. Really appreciate you taking the time to track this down and submit a PR! 🙏

Merged in: #270

[beveradb]

These changes will be available in version 0.42.1 (release PR: #271).