fix: prevent chunk overwrite with custom output names, clarify demucs defaults#270
Merged
Merged
Conversation
… defaults Fix chunking bug where custom_output_names passed to _separate_file caused chunks to overwrite each other (fixes #259). Custom names are now only applied to the final merged output. Adds regression test with multi-chunk + multi-stem scenario that verifies _separate_file is called without custom names. Also clarifies demucs_params segment_size documentation: "Default" maps to 40 for older Demucs models and 10 for Demucs v4/htdemucs. Incorporates work from PR #260 (@Kulin-Soni) and PR #264 (@Madduri-Ganesh) with additional test coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 17, 2026
beveradb
added a commit
that referenced
this pull request
Mar 17, 2026
beveradb
added a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
Summary
custom_output_namesfrom per-chunk_separate_filecall in_process_with_chunking. When custom names were passed to each chunk, they'd all get the same filename and overwrite each other. Custom names are now only applied to the final merged output.demucs_paramssegment_size"Default" uses the model's internal default (40 for older Demucs, 10 for Demucs v4/htdemucs)._separate_fileis called without custom names per chunk.Incorporates work from #260 (thanks @Kulin-Soni!) and #264 (thanks @Madduri-Ganesh!) with additional test coverage.
Test plan
_separate_filecalled WITHOUTcustom_output_namesfor each chunkdemucs.py(40) andhtdemucs.py(10)🤖 Generated with Claude Code